Re: svn commit: r1329609 - in /subversion/trunk/subversion: include/svn_error.h libsvn_fs/fs-loader.c

On Wed, Apr 25, 2012 at 04:24, Daniel Shahaf <danielsh_at_elego.de> wrote:
>...
> SVN_ERR_ASSERT(x) === SVN_ERR_ASSERT(x, SVN_NO_ERROR)
>
> Still, I would prefer not to deprecate SVN_ERR_ASSERT() because that
> would kill readability for the 99% common case.  So:
>
> - I'll redefine SVN_ERR_ASSERT() as above

Does that imply a compose_create() call where arg2 is always SVN_NO_ERROR? Ugh.

> - I'll rename SVN_ERR_ASSERT2() to SVN_ERR_ASSERT_CHAIN()

+1

(I'd also be +0 for SVN_ERR_ASSERT_C())

Cheers,
-g
Received on 2012-04-25 10:36:19 CEST