> -----Original Message-----
> From: MARTIN PHILIP [mailto:codematters_at_ntlworld.com] On Behalf Of Philip
> Martin
> Sent: dinsdag 24 april 2012 14:48
> To: Dmitry Pavlenko
> Cc: dev_at_subversion.apache.org
> Subject: Re: update without changes: broken lock removed, no notifications
> generated
>
> Dmitry Pavlenko <pavlenko_at_tmatesoft.com> writes:
>
> > So I propose to add (lock_state != svn_wc_notify_lock_state_unchanged)
> > condition somewhere to SVN 1.7
>
> Sounds reasonable. Are you going to write a patch? How about extending
> lock_tests.py:defunct_lock, or write a new test, to check the
> notification?
>
> >(maybe not only to close_file but to close_directory too).
>
> Does that achieve anything? Directories can't be locked. I suppose an
> update could change a locked file into a directory but that gives 'D'
> notification for the file and 'A' for the directory.
This is a specific case where the update editor retrieves just
non-operational changes for the file (if there were operational changes it
would have the edited flag would be true).
I agree that this should have been notified in one way or another. But not
in 100% the same way as 1.6, as that triggered tree conflicts if the node or
a parent was shadowed by a delete or replace. (That was the reason to
introduce the edited flag)
Bert
Received on 2012-04-24 15:10:36 CEST