Re: svn commit: r1329015 - in /subversion/trunk/subversion: include/private/svn_ra_private.h libsvn_ra/editor.c libsvn_ra/ra_loader.c libsvn_ra/ra_loader.h

On Mon, Apr 23, 2012 at 16:21, Hyrum K Wright <hyrum.wright_at_wandisco.com> wrote:
> On Mon, Apr 23, 2012 at 12:52 PM, Greg Stein <gstein_at_gmail.com> wrote:
>...
>> Alright. It sounds like svn_ra.h has two purposes: stuff for libsvn_client,
>> and stuff for all RA layers to use internally. Ugh.
>
> But the capability strings are part of the public API.

Says who? Not server Ev2 support. The RA layer can isolate that, so it
should not be "part of the public API".

Mergeinfo support? Sure. But Ev2? Nah.

> svn_ra_has_capability() expects them as input, and it makes sense to
> define them in a public place.  Consumers external to the ra libs can
> realistically be expected to ask this question, so I don't see a
> problem with them being in the public space.

I don't see it as realistic. You just use the Ev2 interface and be done with it.

>...

Cheers,
-g
Received on 2012-04-23 23:55:40 CEST