Re: Failing test basic_tests.py 29 (check that repos root gets set on checkout)

On Wed, Apr 18, 2012 at 7:49 AM, Daniel Shahaf <danielsh_at_elego.de> wrote:
> Hyrum K Wright wrote on Tue, Apr 17, 2012 at 16:27:00 -0500:
>> On Tue, Apr 17, 2012 at 4:05 PM, Johan Corveleyn <jcorvel_at_gmail.com> wrote:
>> > On Tue, Apr 17, 2012 at 10:55 PM, Hyrum K Wright
>> > <hyrum.wright_at_wandisco.com> wrote:
>> >> On Tue, Apr 17, 2012 at 3:48 PM, Johan Corveleyn <jcorvel_at_gmail.com> wrote:
>> >>> On Tue, Apr 17, 2012 at 10:42 AM, Philip Martin
>> >>> <philip.martin_at_wandisco.com> wrote:
>> >>>> Johan Corveleyn <jcorvel_at_gmail.com> writes:
>> >>>>
>> >>>>> Apparently, the test is comparing the 'Repository Root' from the
>> >>>>> output of 'svn info' with the expected repository url. When I run 'svn
>> >>>>> info' manually on ...\svn-test-work\working_copies\basic_tests-29, I
>> >>>>> see the following:
>> >>>>>
>> >>>>> [[[
>> >>>>> Path: R:\test\subversion\tests\cmdline\svn-test-work\working_copies\basic_tests-29
>> >>>>> Working Copy Root Path:
>> >>>>> R:\test\subversion\tests\cmdline\svn-test-work\working_copies\basic_tests-29
>> >>>>> URL: file:///R%7C/test/subversion/tests/cmdline/svn-test-work/local_tmp/repos
>> >>>>> Repository Root:
>> >>>>> file:///R%7C/test/subversion/tests/cmdline/svn-test-work/local_tmp/repos
>> >>>>> ]]]
>> >>>>>
>> >>>>> So the '%7C' instead of ':' seems to be the problem (BTW, %7C is the
>> >>>>> pipe symbol, which seems quite strange here).
>> >>>>>
>> >>>>> When I use the same svn binary to do a new checkout of the same
>> >>>>> repository, over file://, I don't get this problem. So that indicates
>> >>>>> it's a problem with the test suite.
>> >>>>
>> >>>> tests.log should show the exact command used to do the checkout.  Is it
>> >>>> the same as the command you are running manually?

[ snip stuff about test output (loglevel) problems, for which Hyrum,
followed by Daniel suggested ... ]

>> Run running individual tests, you can run them with
>> --set-log-level=INFO.  I do not know how this translates to
>> win-tests.py, or if win-tests.py propagates that information to child
>> tests.
>
> Pass set_log_level=logging.DEBUG to TestHarness.__init__().

Thanks, that helped (level INFO sufficed)

So, now I see that every single file:/// url in all of basic_tests.py
(and probably all my other tests as well) is used as

    "file:///R|/test/subversion/tests/cmdline..."

Huh? And that even works? Yes, I just tried it manually on the commandline.

I'm a bit stumped actually.

Apart from the fact that I'm surprised that this works:
- Did something change in the testsuite? Ah yes, because I'm not
seeing this with 1.7.4 (there I see "file:///R:/test/..." everywhere
in the logs). So where, what, ... ?
- Why am I the only one seeing this? The (Windows) buildbots don't seem to fail.
- This is just a testsuite issue, right? The testsuite uses the
"repository root" in its original form for comparison in
basis_tests.py#29, instead of in its encoded form. It is intended
functionality that "svn info" shows the repository url in encoded
form, right? And it is supposed to encode the pipe symbol, right?

-- 
Johan