[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1328595 - /subversion/branches/compressed-pristines/subversion/libsvn_wc/wc_db.c

From: Greg Stein <gstein_at_gmail.com>
Date: Sat, 21 Apr 2012 18:15:17 -0400

On Sat, Apr 21, 2012 at 03:03, <ashod_at_apache.org> wrote:
> Author: ashod
> Date: Sat Apr 21 07:03:51 2012
> New Revision: 1328595
>
> URL: http://svn.apache.org/viewvc?rev=1328595&view=rev
> Log:
> Pristine.db created during db-init.
> ** Checkpoint: raw code. Not ready for review yet! **

I would recommend adding log messages to describe what you're doing.
The log message can say something like "draft code to do $FOO", or
"interim code, will fix in future revision". With a solid set of log
messages, then we'll have a better idea of what is going on, how you
got there, etc. If the log message always said "working on compressed
pristines", until you were done where it says "merge compressed
pristines to trunk", then you'd be in trouble :-)

Also: people *will* continue to review the changes. We don't want code
to spring fully-formed on us, but to review and comment on each step
in its evolution.

I would also recommend getting some practice with our log message
format. The message might look something like:

----
On the compressed-pristines branch:
Create the pristine.db during db initialization.
* subversion/libsvn_wc/wc_db.c:
  (svn_wc__db_init): call create_pristine_db()
----
Cheers,
-g
Received on 2012-04-22 00:15:50 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.