Re: svn commit: r1327979 - in /subversion/trunk/subversion: include/private/svn_repos_private.h libsvn_fs/fs-loader.c libsvn_repos/fs-wrap.c mod_dav_svn/repos.c

On Apr 19, 2012 12:18 PM, "Philip Martin" <philip.martin_at_wandisco.com>
wrote:
>
> Greg Stein <gstein_at_gmail.com> writes:
>
> > On Apr 19, 2012 11:02 AM, <philip_at_apache.org> wrote:
> >>...
> >> +++ subversion/trunk/subversion/libsvn_fs/fs-loader.c Thu Apr 19
15:02:17
> > 2012
> >>...
> >> + if (kind == svn_node_dir)
> >> + {
> >> + svn_error_clear(err);
> >> + *fs_type = apr_pstrdup(pool, SVN_FS_TYPE_BDB);
> >> + return SVN_NO_ERROR;
> >
> > There's no need to dup a constant string.
>
> I moved that code without considering that. The documentation
> explicitly states that the result is allocated in pool but I think we
> can change that. It also allows me to rename pool to scratch_pool. I
> suppose there is a theoretical problem if libsvn_fs is dynamically
> loaded and the caller is passing a pool with a longer lifetime than the
> library. The constant string in the dynamic library would then have a
> shorter lifetime than it does now. Unlikely in practice I think.

Do we ever unload the modules? I know mod_dav_svn.so can get unloaded. But
FS modules?

Cheers,
-g
Received on 2012-04-19 20:30:04 CEST