Re: svn commit: r1327695 - /subversion/trunk/subversion/libsvn_subr/checksum.c

On 04/18/2012 02:54 PM, Greg Stein wrote:
> On Wed, Apr 18, 2012 at 17:52,<blair_at_apache.org> wrote:
>> ...
>> +++ subversion/trunk/subversion/libsvn_subr/checksum.c Wed Apr 18 21:52:01 2012
>> @@ -56,25 +56,43 @@ validate_kind(svn_checksum_kind_t kind)
>> return svn_error_create(SVN_ERR_BAD_CHECKSUM_KIND, NULL, NULL);
>> }
>>
>> +/* Create a svn_checksum_t with everything but the contents of the
>> + digest populated. */
>> +static svn_checksum_t *
>> +checksum_create(svn_checksum_kind_t kind,
>> + apr_size_t digest_size,
>> + apr_pool_t *pool)
>> +{
>> + // Use apr_palloc() instead of apr_pcalloc() so that the digest
>> + // contents are only set once by the caller.
>
> No C++ style comments, please...

Oops, thanks. Been coding in C++ too long. Fixed in r1327708.

Blair
Received on 2012-04-19 00:26:38 CEST