On Tue, Apr 17, 2012 at 4:05 PM, Johan Corveleyn <jcorvel_at_gmail.com> wrote:
> On Tue, Apr 17, 2012 at 10:55 PM, Hyrum K Wright
> <hyrum.wright_at_wandisco.com> wrote:
>> On Tue, Apr 17, 2012 at 3:48 PM, Johan Corveleyn <jcorvel_at_gmail.com> wrote:
>>> On Tue, Apr 17, 2012 at 10:42 AM, Philip Martin
>>> <philip.martin_at_wandisco.com> wrote:
>>>> Johan Corveleyn <jcorvel_at_gmail.com> writes:
>>>>
>>>>> Apparently, the test is comparing the 'Repository Root' from the
>>>>> output of 'svn info' with the expected repository url. When I run 'svn
>>>>> info' manually on ...\svn-test-work\working_copies\basic_tests-29, I
>>>>> see the following:
>>>>>
>>>>> [[[
>>>>> Path: R:\test\subversion\tests\cmdline\svn-test-work\working_copies\basic_tests-29
>>>>> Working Copy Root Path:
>>>>> R:\test\subversion\tests\cmdline\svn-test-work\working_copies\basic_tests-29
>>>>> URL: file:///R%7C/test/subversion/tests/cmdline/svn-test-work/local_tmp/repos
>>>>> Repository Root:
>>>>> file:///R%7C/test/subversion/tests/cmdline/svn-test-work/local_tmp/repos
>>>>> ]]]
>>>>>
>>>>> So the '%7C' instead of ':' seems to be the problem (BTW, %7C is the
>>>>> pipe symbol, which seems quite strange here).
>>>>>
>>>>> When I use the same svn binary to do a new checkout of the same
>>>>> repository, over file://, I don't get this problem. So that indicates
>>>>> it's a problem with the test suite.
>>>>
>>>> tests.log should show the exact command used to do the checkout. Is it
>>>> the same as the command you are running manually?
>>>
>>> Gahh! For some reason tests.log doesn't show much detail:
>>>
>>> [[[
>>> ...
>>> PASS: basic_tests.py 26: basic info command
>>> PASS: basic_tests.py 27: ignore files matching local ignores in added dirs
>>> PASS: basic_tests.py 28: add ignored files in added dirs
>>> 2012-04-17 22:38:44 [WARNING] Bad or missing repository root
>>> 2012-04-17 22:38:44 [WARNING]
>>> Traceback (most recent call last):
>>> File "C:\research\svn\client_build\trunk2\subversion\tests\cmdline\svntest\main.py",
>>> line 1332, in run
>>> rc = self.pred.run(sandbox)
>>> File "C:\research\svn\client_build\trunk2\subversion\tests\cmdline\svntest\testcase.py",
>>> line 176, in run
>>> return self.func(sandbox)
>>> File "C:\research\svn\client_build\trunk2\subversion\tests\cmdline\basic_tests.py",
>>> line 1709, in repos_root
>>> check_repos_root(output)
>>> File "C:\research\svn\client_build\trunk2\subversion\tests\cmdline\basic_tests.py",
>>> line 1703, in check_repos_root
>>> raise svntest.Failure
>>> Failure
>>> FAIL: basic_tests.py 29: check that repos root gets set on checkout
>>> PASS: basic_tests.py 30: checks peg revision on filename with @ sign
>>> PASS: basic_tests.py 31: info on file not existing in HEAD
>>> ...
>>> ]]]
>>>
>>> I tried adding -v to win-tests.py, but that didn't increase the
>>> verbosity level of the logging.
>>>
>>> What am I missing? How can I get the usual (old) verbosity back in the log file?
>>>
>>> I remember reading commits and some discussion about using the python
>>> logging framework from the test-suite ... but don't know the details.
>>> Is this supposed to be backward compatible, and show the same
>>> log-level as there used to be?
>>
>> The logging framework has a significant amount of granularity, but in
>> replacing print() with logger.foo(), we may have erred on the side of
>> being a bit too conservative in the amount of stuff printed by
>> default. My guess is that the information you are looking for is
>> currently hidden by logger.info(), but should be logger.warn().
>
> Hm, maybe, maybe not. What I'm looking for is the exact svn commands
> that were executed. I think those were previously printed as "CMD:
> ******" or something like that. I'm not sure if I'd call that a "warn"
> loglevel. But then again, I'm not really sure what we want to end up
> with. Is it ok for the test suite to be this verbose by default (and
> thus show every command executed with "warn" loglevel)?
>
> It would also be ok for me if those are logged with "info" level, if
> only I knew how to tune the logging configuration to write out
> everything from info level. Is there a way to do just that?
Run running individual tests, you can run them with
--set-log-level=INFO. I do not know how this translates to
win-tests.py, or if win-tests.py propagates that information to child
tests.
-Hyrum
--
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Received on 2012-04-17 23:27:34 CEST