Re: svn commit: r1326688 - /subversion/trunk/subversion/tests/libsvn_subr/named_atomic-test.c

On Apr 16, 2012 1:25 PM, <stefan2_at_apache.org> wrote:
>
> Author: stefan2
> Date: Mon Apr 16 17:25:18 2012
> New Revision: 1326688
>
> URL: http://svn.apache.org/viewvc?rev=1326688&view=rev
> Log:
> Skip named_atomics tests if the user does not have the necessary
> privileges under Windows.
>
> * subversion/tests/libsvn_subr/named_atomic-test.c
> (has_sufficient_privileges): new function
> (test_basics, test_bignums, test_multiple_atomics,
> test_namespaces, test_multithreaded, test_multiprocess): call it

Don't we have something like SVN_TEST_SKIP(foo,
has_sufficient_privileges()) ?

That will produce "skipped" in the output. At a minimum the test should
return the ERR_SKIPPED "error" to produce the right output.

I also find the need for the has_sufficient_privileges() function to be
problematic. It seems to indicate you have not encapsulated this stuff
properly.

Cheers,
-g
Received on 2012-04-16 19:46:14 CEST