[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1325478 - in /subversion/trunk/subversion: include/svn_pools.h libsvn_subr/pool.c

From: Stefan Fuhrmann <stefanfuhrmann_at_alice-dsl.de>
Date: Fri, 13 Apr 2012 17:31:23 +0200

Am 13.04.2012 18:44, schrieb Philip Martin:
> Stefan Fuhrmann<stefanfuhrmann_at_alice-dsl.de> writes:
>
>> Am 13.04.2012 16:35, schrieb Daniel Shahaf:
>>> stefan2_at_apache.org wrote on Thu, Apr 12, 2012 at 20:02:37 -0000:
>>>> + * @since: New in 1.8
>>>> + */
>>>> +apr_allocator_t *
>>>> +svn_pool_create_allocator(svn_boolean_t thread_safe);
>>> Should this be an svn-private API? Should it take a parameter
>>> that allows overriding the SVN_ALLOCATOR_RECOMMENDED_MAX_FREE default?
>>>
>> Not too long ago, I spent a couple of days hunting
>> memory corruptions. The reason turned out to be
>> the allocator not being thread-safe by default while
>> the default allocator was.
> If that's correct then this bug is present in all Subversion releases;
> does it affect threaded Apache or threaded svnserve? Do we need to
> backport to 1.7 and 1.6?
>
I thought the same thing but in SVN, in those few places
where we use multiple threads, we actually create an
allocator per thread.

The problem only occurs if you e.g. want to use a single
allocator throughout your multi-threaded application.

-- Stefan^2.
Received on 2012-04-13 19:32:18 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.