RE: build probs on Windows with release build and conditionally

 defined symbols (SVN_WITH_SYMMETRIC_MERGE)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

You probably need a other gen-make.py call to regenerate the .def files
before building.

Bert Huijben (Cell phone)
From: Johan Corveleyn
Sent: 10-4-2012 3:20
To: Subversion Development
Subject: build probs on Windows with release build and conditionally
defined symbols (SVN_WITH_SYMMETRIC_MERGE)
Hi,

I haven't built trunk for a while, and now that I'm catching up I get
the following build errors (with my release build):

libsvn_client.def : error LNK2001: unresolved external symbol
svn_client__do_symmetric_merge
libsvn_client.def : error LNK2001: unresolved external symbol
svn_client__find_symmetric_merge
..\..\..\Release\subversion\libsvn_client\libsvn_client-1.lib : fatal
error LNK1120: 2 unresolved externals

Apparently, this is because these symbols are expected to be there,
but during the build they aren't because they're conditional on
SVN_WITH_SYMMETRIC_MERGE (which is defined in svn_client_private.h in
an #ifdef SVN_DEBUG block, so this is only defined with a debug build,
not with a release build).

(This reminds me of a similar problem I had a couple of months ago
with some debug helpers which were also only defined conditional on
SVN_DEBUG. I fixed it by moving the #ifdef SVN_DEBUG markers a bit
deeper so the functions were always declared / defined).

Anyway, I'm just noting it here, before I go disconnected for a couple
of days. I don't know how to fix it right now (except by always
enabling SVN_WITH_SYMMETRIC_MERGE, regardless of debug). And maybe
this is just a temporary situation anyway, so no biggie. But if anyone
can address this, all the better :-).

-- 
Johan