[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1308372 - /subversion/trunk/subversion/libsvn_subr/crypto.c

From: Greg Stein <gstein_at_gmail.com>
Date: Mon, 2 Apr 2012 19:52:39 -0400

On Mon, Apr 2, 2012 at 10:57, <cmpilato_at_apache.org> wrote:
> Author: cmpilato
> Date: Mon Apr  2 14:57:14 2012
> New Revision: 1308372
> URL: http://svn.apache.org/viewvc?rev=1308372&view=rev
> Log:
> Some cleanups and minor tweaks to the crypto code.
> * subversion/libsvn_subr/crypto.c
>  (crypto_init): Remove unnecessary #if-wrapping (APU_HAVE_CRYPTO).
>    While here, re-wrap (in a different sense of the word) some code.

To be honest, one of my intended updates is to move *all* of the
#ifdef stuff into crypto.c's functions. We've had problems where
functions only appeared within certain build targets (notably under
Windows). I think that the functions should always be available, but
just return errors if the underlying library support is not present.
Thus, callers never need to understand the vagaries of when something
is/not available. Throw in an svn_crypto__is_available(), and it makes
things even a bit easier.

Any issues with that approach, that you can see?

Received on 2012-04-03 01:53:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.