Re: svn commit: r1308470 - in /subversion/trunk/subversion: libsvn_subr/crypto.c tests/libsvn_subr/crypto-test.c

On Mon, Apr 2, 2012 at 15:10, <cmpilato_at_apache.org> wrote:
> Author: cmpilato
> Date: Mon Apr  2 19:10:26 2012
> New Revision: 1308470
>
> URL: http://svn.apache.org/viewvc?rev=1308470&view=rev
> Log:
> Finish up the initial password encryption and decryption routines, and
> stare in amazement as the tests now pass.  For me.  On my box.
>
> * subversion/libsvn_subr/crypto.c
>  (svn_crypto__encrypt_password): Per our plan, prepend the prefix to
>    the password and pad up to the specified block size before
>    encrypting.  Lose a seemingly unfounded assertion (that the size
>    of the input will match that of the output).

What were you seeing? The encryption result *should* match the amount
of data we passed. N blocks of input data for N blocks of output data.
If they don't match, then something *is* wrong, as noted in the
assertion's comment.

>...

Cheers,
-g
Received on 2012-04-02 21:40:47 CEST