[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1295148 - /subversion/trunk/subversion/include/svn_error.h

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 29 Feb 2012 16:29:30 -0500

Thanks for the recompile.

;-)
On Feb 29, 2012 10:20 AM, <hwright_at_apache.org> wrote:

> Author: hwright
> Date: Wed Feb 29 15:20:18 2012
> New Revision: 1295148
>
> URL: http://svn.apache.org/viewvc?rev=1295148&view=rev
> Log:
> When running the clang static analyzer, it is useful to use a vanilla
> assert,
> rather than our custom one, so make it so.
>
> * subversion/include/svn_error.h
> (SVN_ERR_ASSERT): Optionally alias to assert() if running in the clang
> static
> analyzer.
>
> Modified:
> subversion/trunk/subversion/include/svn_error.h
>
> Modified: subversion/trunk/subversion/include/svn_error.h
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_error.h?rev=1295148&r1=1295147&r2=1295148&view=diff
>
> ==============================================================================
> --- subversion/trunk/subversion/include/svn_error.h (original)
> +++ subversion/trunk/subversion/include/svn_error.h Wed Feb 29 15:20:18
> 2012
> @@ -479,11 +479,16 @@ svn_error_t *svn_error_purge_tracing(svn
> *
> * @since New in 1.6.
> */
> +#ifdef __clang_analyzer__
> +#include <assert.h>
> +#define SVN_ERR_ASSERT(expr) assert((expr))
> +#else
> #define SVN_ERR_ASSERT(expr) \
> do { \
> if (!(expr)) \
> SVN_ERR(svn_error__malfunction(TRUE, __FILE__, __LINE__, #expr)); \
> } while (0)
> +#endif
>
> /** Similar to SVN_ERR_ASSERT(), but without the option of returning
> * an error to the calling function.
>
>
>
Received on 2012-02-29 22:30:03 CET

This is an archived mail posted to the Subversion Dev mailing list.