[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1293998 - /subversion/trunk/subversion/libsvn_repos/replay.c

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Mon, 27 Feb 2012 15:33:46 +0200

Julian Foad wrote on Mon, Feb 27, 2012 at 10:19:35 +0000:
> Daniel Shahaf wrote:
> >> danielsh_at_apache.org wrote:
> >> > Fix issue #4121: svnsync of a copy followed by delete of
> >> > was-unreadable child.
> >> > http://subversion.tigris.org/issues/show_bug.cgi?id=4121
> >> >
> >> > * subversion/libsvn_repos/replay.c
> >> >  (was_readable): New helper.
> >> >  (path_driver_cb_func):
> >> >    Use new helper to determine whether to replay or discard
> >> > deletions.
> >>
> >> I've been trying to write a regression test for this, but got stuck
> >> converting my shell script to Python.
> >>
> >> I have a shellscript (attached) that reproduces the issue for me: with
> >> r1293997 it outputs
> >>
> >>     Copied properties for revision 1.
> >>     subversion/libsvn_ra_svn/client.c:2440: (apr_err=210008)
> >>     svnsync: E210008: Error while replaying commit
> >>     zsh: exit 1    ./01repro
> >>
> >> I am also attaching an attempt at an equivalent Python test.  For me the
> >> Python test passes against r1293997.  Can anyone spot the difference?
>
> Your Python test fails against r1293997 and passes against r1293998 for me.  The fail against r1293997 looks like:
>
> [...]
...
> /home/julianfoad/src/subversion-c/subversion/libsvn_ra_neon/replay.c:181: (apr_err=160028)
...
> svnsync: E160028: '/branch/A' is out of date
> [...]
>
> - Julian

Thanks for your help. Between this and discussions with philipm on IRC,
we've tracked down the problem to a difference in svnserve/mod_dav_svn's
expectations from authz files which the test suite didn't account for.
(More precisely, teh test I modeled my new test after was in itself
silently broken; the other svnsync_tests were fine.)

All fixed now, and I'll see about updating docs too.

Thanks to you and Philip for the help.

Daniel
Received on 2012-02-27 14:38:31 CET

This is an archived mail posted to the Subversion Dev mailing list.