[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1292047 - in /subversion/trunk/subversion/libsvn_client: add.c copy.c delete.c prop_commands.c

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 21 Feb 2012 18:54:46 -0500

On Tue, Feb 21, 2012 at 16:44, <hwright_at_apache.org> wrote:
> Author: hwright
> Date: Tue Feb 21 21:44:13 2012
> New Revision: 1292047
>
> URL: http://svn.apache.org/viewvc?rev=1292047&view=rev
> Log:
> Ev2 shims: Register the appropriate callbacks for use with the Ev2 shims every
> time we fetch a commit editor from within the client.

I think you've leaked the "hidden shims" out too far with this change.
Can't you put it back where you just registered the shims for every RA
session. It certainly doesn't hurt to put them into the session, and
let them be unused.

On the baton, you're passing NULL for all of these, so it would seem
that you could do the same when creating the RA session and installing
shims. If you *do* need the baton sometimes, then pass the baton into
the client-internal RA session creation.

... something. It just seems that we shouldn't be seeing this
registration everywhere.

Cheers,
-g
Received on 2012-02-22 00:55:20 CET

This is an archived mail posted to the Subversion Dev mailing list.