[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1242607 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

From: Greg Stein <gstein_at_gmail.com>
Date: Thu, 9 Feb 2012 19:29:17 -0500

Ah, good one.
On Feb 9, 2012 6:45 PM, <danielsh_at_apache.org> wrote:

> Author: danielsh
> Date: Thu Feb 9 23:45:03 2012
> New Revision: 1242607
>
> URL: http://svn.apache.org/viewvc?rev=1242607&view=rev
> Log:
> Convert asserts into errors.
>
> * subversion/libsvn_ra_serf/update.c
> (start_report): Gracefully error out on unknown children tags
> of ADD_FILE/OPEN_FILE/ADD_DIR/OPEN_DIR.
>
> Modified:
> subversion/trunk/subversion/libsvn_ra_serf/update.c
>
> Modified: subversion/trunk/subversion/libsvn_ra_serf/update.c
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/update.c?rev=1242607&r1=1242606&r2=1242607&view=diff
>
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_ra_serf/update.c (original)
> +++ subversion/trunk/subversion/libsvn_ra_serf/update.c Thu Feb 9
> 23:45:03 2012
> @@ -1691,7 +1691,9 @@ start_report(svn_ra_serf__xml_parser_t *
> }
> else
> {
> - SVN_ERR_MALFUNCTION();
> + return svn_error_createf(SVN_ERR_RA_DAV_MALFORMED_DATA, NULL,
> + _("Unknown tag '%s' while at state
> %d"),
> + name.name, state);
> }
>
> }
> @@ -1766,7 +1768,9 @@ start_report(svn_ra_serf__xml_parser_t *
> }
> else
> {
> - SVN_ERR_MALFUNCTION();
> + return svn_error_createf(SVN_ERR_RA_DAV_MALFORMED_DATA, NULL,
> + _("Unknown tag '%s' while at state
> %d"),
> + name.name, state);
> }
> }
> else if (state == IGNORE_PROP_NAME)
>
>
>
Received on 2012-02-10 01:29:52 CET

This is an archived mail posted to the Subversion Dev mailing list.