On Thu, Feb 9, 2012 at 6:32 PM, Mark Phippard <markphip_at_gmail.com> wrote:
> On Thu, Feb 9, 2012 at 12:26 PM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
>
>> Bah. I'd be surprised if most of our editors supported postfix text deltas.
>> To my knowledge, there is exactly one driver which uses that approach in
>> our own codebase (the commit driver). So, I can easily forgive svnrdump's
>> dump editor (and any other non-commit editor) for not supporting postfix
>> text deltas. That's one of two valid "modes" of an editor drive -- one
>> rarely used in practice.
>>
>> ra_serf has a well-established history (and intentional design) which
>> violates a far more fundamental editor restriction which applies to both
>> "modes" -- depth-first-ness. (See
>> http://subversion.tigris.org/issues/show_bug.cgi?id=2932 for details.) This
>> is why I'm more apt to think that the problem here is with ra_serf than with
>> svnrdump.
>
> In terms of 1.7.3, which is the scope of this discussion, the only
> thing that should be relevant is whether this is a significant
> regression from previous 1.7 releases. If we tolerated the bug for
> 1.7.0 there is no point in holding up 1.7.3 while we discuss it.
The "dangerous behavior" may have been present in 1.7.0 already, but
1.7.3 will be the first release where this appeared to cause a real
issue. I mean, for some reason the bug (or manifestation of the
"lingering bug") first appeared on 1.7.x after r1239697 (backport of
r1237720 and r1239596 (stuff in mod_dav_svn/liveprops.c) from trunk).
Also: the problem is related to the server-side (mod_dav_svn), which
means svnrdump over serf will be problematic with 1.7.3 servers.
Disclaimer: I don't feel strongly at all about this problem, either
way. In fact, I don't really care. I just happen to be one of the few
people who can reproduce the problem, so I'm trying my best to
investigate it in any way I can and present the information.
--
Johan
Received on 2012-02-09 19:10:49 CET