Matthijs Kooijman wrote on Tue, Feb 07, 2012 at 17:14:32 +0100:
> Hi Stefan,
> > It appears the attachment is missing.
> Yeah, motoric memory took over and I sent the mail, while I intended to
> actually test the patches again before resending.
> So, here's the updated _and_ tested patches, attached this time.
> Index: subversion-trunk/tools/examples/get-location-segments.py
> --- subversion-trunk.orig/tools/examples/get-location-segments.py 2012-02-07 16:19:07.413853775 +0100
> +++ subversion-trunk/tools/examples/get-location-segments.py 2012-02-07 16:20:36.914353499 +0100
> @@ -125,7 +125,13 @@
> ctx = client.svn_client_create_context()
> - providers = [
> + # Make sure that these are at the start of the list, so passwords from
> + # gnome-keyring / kwallet are checked before asking for new passwords.
> + # Note that we don't pass our config here, since we can't seem to access
> + # ctx.config.config (ctx.config is opaque).
What do you mean by that?
% PYTHONPATH=$prefix/svn-t1/lib/svn-python/ \
python -c 'import svn, svn.core, svn.client;
print svn.core.svn_config_get_config(None, None)["config"]'
<libsvn.core.svn_config_t; proxy of <Swig Object of type 'svn_config_t *' at 0xb734d998> >
> +++ subversion-trunk/subversion/bindings/swig/python/tests/client.py 2012-02-07 16:20:36.914353499 +0100
> @@ -374,6 +374,11 @@
> self.assertEqual(readme_text, 'This is a test.\n')
> + def test_platform_providers(self):
> + providers = core.svn_auth_get_platform_specific_client_providers(None, None)
> + # Not much more we can test in this minimal environment.
> + self.assert_(isinstance(providers, list))
You could assert
all(map(lambda x: isinstance(x, 'svn_auth_provider_object_t *'),
like the Perl revision you refer to does.
I've committed this patch. (I had to rewrite the log message to conform
to our style of mentioning every symbol.) Please send followups as
patches against the new HEAD.
Received on 2012-02-07 18:46:56 CET