[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Why do we check the base checksum so often?

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Tue, 7 Feb 2012 00:39:59 +0200

Greg Stein wrote on Mon, Feb 06, 2012 at 17:26:59 -0500:
> On Mon, Feb 6, 2012 at 17:13, Daniel Shahaf <danielsh_at_elego.de> wrote:
> > Greg Stein wrote on Mon, Feb 06, 2012 at 17:06:54 -0500:
> >> On Mon, Feb 6, 2012 at 15:55, Daniel Shahaf <danielsh_at_elego.de> wrote:
> >> > Greg Stein wrote on Mon, Feb 06, 2012 at 15:49:10 -0500:
> >> >> On Mon, Feb 6, 2012 at 15:44, C. Michael Pilato <cmpilato_at_collab.net> wrote:
> >> >> > On 02/06/2012 03:41 PM, Greg Stein wrote:
> >> >> >> That is certainly an easier approach. "You use the old interface?
> >> >> >> Fine. You won't get base checksum verification cuz we'll always pass
> >> >> >> NULL." ... that seems like a fine position to take.
> >> >> >
> >> >> > This might be a fine position to take for some third-party consumer of the
> >> >> > APIs, but I hope you aren't advocating that we toss out such a core data
> >> >> > integrity check within Subversion itself.  Are you?
> >> >>
> >> >> Theoretically, we'll be converted over to Ev2 and the compatibility
> >> >> shim will not be used in our product. Only third-parties who choose to
> >> >> stick to the old Ev1 (delta editor) interfaces will lose the integrity
> >> >> check.
> >> >>
> >> >
> >> > And Subversion 1.7 clients.
> >>
> >> Are you talking about 'svn', or something like TortoiseSVN? The former
> >> will use Ev2, so the shim won't be used. The latter will not get the
> >> additional integrity check if it continues to use the Ev1 interfaces.
> >
> > I am talking about svn 1.7.0 --- how will it use Ev2?
>
> Hunh? Not at all. Ev2 won't be used in svn until 1.8 at the very
> earliest, but more likely 1.9.
>
> What am I missing about your question? Ev2 is simply nowhere in 1.7.x.
>

1. Third-parties who use Ev1 interface would lose the integrity check.

2. Subversion 1.7 uses, and will use, Ev1 interfaces.

Therefore:

3. Subversion 1.7 would lose the integrity check.

Correct?

> Cheers,
> -g
Received on 2012-02-06 23:45:15 CET

This is an archived mail posted to the Subversion Dev mailing list.