[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1241050 - /subversion/trunk/subversion/mod_dav_svn/mod_dav_svn.c

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Mon, 6 Feb 2012 18:20:28 +0200

Stefan Sperling wrote on Mon, Feb 06, 2012 at 17:12:32 +0100:
> On Mon, Feb 06, 2012 at 05:59:04PM +0200, Daniel Shahaf wrote:
> > This still strips whitespace around ='s in the value:
> > SVNHooksEnv "name = x = y"
> > will result in
> > setenv("name", "x=y", 1)
> > whereas I believe it should result in
> > setenv("name", "x = y", 1)
> > (and, to be honest, I'd be happy with
> > setenv("name ", " x = y", 1)
> > as well).
> >
> > WDYT? How should it behave?
>
> I agree.
> would telling svn_cstring_split() to no strip whitespace suffice?

I assume that should result in the third setenv() case above, so +1.
Received on 2012-02-06 17:21:18 CET

This is an archived mail posted to the Subversion Dev mailing list.