[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1241025 - in /subversion/trunk/subversion: include/svn_checksum.h libsvn_subr/checksum.c tests/libsvn_subr/checksum-test.c

From: Hyrum K Wright <hyrum.wright_at_wandisco.com>
Date: Mon, 6 Feb 2012 08:59:28 -0600

On Mon, Feb 6, 2012 at 8:50 AM, Daniel Shahaf <danielsh_at_elego.de> wrote:
> hwright_at_apache.org wrote on Mon, Feb 06, 2012 at 14:42:45 -0000:
>> +  checksum = svn_checksum_empty_checksum(svn_checksum_md5, pool);
>> +  SVN_TEST_ASSERT(svn_checksum_is_empty_checksum(checksum));
>> +
>
> That doesn't test much -- both functions just call
> svn_md5__empty_string_digest() which returns a static constant.
>
> Perhaps actually construct an empty svn_string_t and checksum it?

Makes sense: r1241033

-Hyrum

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Received on 2012-02-06 16:00:03 CET

This is an archived mail posted to the Subversion Dev mailing list.