Re: svn commit: r1239926 - in /subversion/trunk/subversion: include/svn_repos.h libsvn_repos/hooks.c libsvn_repos/repos.c libsvn_repos/repos.h

On 02/02/2012 05:07 PM, Stefan Sperling wrote:
> On Thu, Feb 02, 2012 at 03:41:48PM -0800, Blair Zajac wrote:
>> It doesn't look like it's multithreaded safe to set, but should it be?
>
> I am not sure.
>
> Note that this isn't changing the environment of the currently running
> process. It takes effect in the child process that runs a hook.
>
> The intended use is to set the hook environment once, after opening
> the repository with svn_repos_open().
>
> I've just committed some code that uses this from mod_dav_svn
> in r1239966. Maybe this example will make the intented use clear, and
> we can document behaviour WRT thread-safety or make the code thread-safe?

I'm reading code too fast today and only noticed after I asked the
question that it's being set on the svn_repos_t instead of globally, so
documenting it seems fine. I don't imagine people having multiple
threads set this.

Blair
Received on 2012-02-03 02:26:59 CET