[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1239926 - in /subversion/trunk/subversion: include/svn_repos.h libsvn_repos/hooks.c libsvn_repos/repos.c libsvn_repos/repos.h

From: Blair Zajac <blair_at_orcaware.com>
Date: Thu, 02 Feb 2012 15:41:48 -0800

On 02/02/2012 03:29 PM, stsp_at_apache.org wrote:
> Author: stsp
> Date: Thu Feb 2 23:29:11 2012
> New Revision: 1239926
>
> URL: http://svn.apache.org/viewvc?rev=1239926&view=rev
> Log:
> Add a public libsvn_repos API to set the environment of hook scripts.
>
> Modified:
> subversion/trunk/subversion/include/svn_repos.h
> subversion/trunk/subversion/libsvn_repos/hooks.c
> subversion/trunk/subversion/libsvn_repos/repos.c
> subversion/trunk/subversion/libsvn_repos/repos.h
>
> Modified: subversion/trunk/subversion/include/svn_repos.h
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_repos.h?rev=1239926&r1=1239925&r2=1239926&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/include/svn_repos.h (original)
> +++ subversion/trunk/subversion/include/svn_repos.h Thu Feb 2 23:29:11 2012
> @@ -764,6 +764,13 @@ const char *
> svn_repos_post_unlock_hook(svn_repos_t *repos,
> apr_pool_t *pool);
>
> +/** Set the environment that @ repos's hooks will inherit.
> + * If this function is not called, hooks will run in an empty environment.
> + * @since New in 1.8. */

Is NULL OK? How is the environment formatted? It's not of the same
form as execve(), which I was surprised by.

It doesn't look like it's multithreaded safe to set, but should it be?

Blair
Received on 2012-02-03 00:42:23 CET

This is an archived mail posted to the Subversion Dev mailing list.