Re: [PATCH] Add description for SVNUseUTF8 (issue #2487)

Stefan Sperling wrote on Thu, Feb 02, 2012 at 21:04:26 +0100:
> On Thu, Feb 02, 2012 at 10:01:23PM +0200, Daniel Shahaf wrote:
> > Actually I was referring to the former: if admins may want to change
> > their hooks for UTF-8 support, then people who write generic hooks will
> > want to have an if() in their code.
>
> What for?
>

So that people can use the hooks regardless of their SVNUseUTF8 setting.

I mean, I didn't invent the concept that people write hooks and publish
it for the world to use. And such hooks need to be robust --- work with
a wide array of server configs.

(The book text implies that people may want to edit their hooks when
they enable SVNUseUTF8)

> > > The easiest thing we could so is to set LC_CTYPE to en_US.UTF-8
> > > in the hook's environment if SVNUseUTF-8 is enabled. This allows
> > > tools like svnlook to procress UTF-8 when invoked from the hook.
> >
> > Locale names aren't too portable, are they?
> >
> > What guarantees that an English locale is installed?
>
> Hmmm... you're right. These names aren't standardized at all.
> Bummer. We'd have to let users pass a locale name via a config option...

I happen to know an httpd module that does that... :P
Received on 2012-02-02 21:18:07 CET