[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add description for SVNUseUTF8 (issue #2487)

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Thu, 2 Feb 2012 21:23:26 +0200

CC += dev@

Stefan Sperling wrote on Thu, Feb 02, 2012 at 19:43:12 +0100:
> On Thu, Feb 02, 2012 at 07:57:58PM +0200, Daniel Shahaf wrote:
> > Neels J Hofmeyr wrote on Thu, Feb 02, 2012 at 17:51:01 +0100:
> > > + becomes possible. Note that your hook scripts must then
> > > + operate in the UTF-8 character set regardless of the
> >
> > How are scripts supposed to know this? Shouldn't we communicate to them
> > the expectations of them (via argv or env)?
>
> Admins are supposed to know this and adjust their hooks accordingly.
>
> Note that before this change non-ASCII didn't work in hooks anyway.
> Existing hooks can only be using ASCII which is a subset of UTF-8.

Right. So now all hooks should grow a config knob "May I output UTF-8?"
(in case they're invoked on an ASCII fspath or repos_path but wish to
output UTF-8). It still appears to me that passing this bit to the
scripts from svn would be a more robust design.
Received on 2012-02-02 20:28:58 CET

This is an archived mail posted to the Subversion Dev mailing list.