[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

dav_svn__insert_all_liveprops asks for directory checksums

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Mon, 30 Jan 2012 17:00:02 +0000

Checkout a working copy that contains versioned directories from a
server using v1 and serf. The network traffic includes

<lp2:md5-checksum>###error###</lp2:md5-checksum>

for each directory. It turns out that dav_svn__insert_all_liveprops
doesn't distinguish between files and directories and attempts to
retreive a checksum for the node irrespective of the type. A recent
change on trunk, r1237720, makes Apache log this error so that adds to
the cost of the operation.

The dav_svn__insert_all_liveprops function is a DAV hook installed with
dav_hook_insert_all_liveprops so I guess that it is possible that other
opeartions may trigger this code. Should dav_svn__insert_all_liveprops
be determining the node type before requesting a checksum?

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com
Received on 2012-02-02 11:55:14 CET

This is an archived mail posted to the Subversion Dev mailing list.