On Tue, Jan 31, 2012 at 11:01 PM, Greg Stein <gstein_at_gmail.com> wrote:
> On Tue, Jan 31, 2012 at 22:50, <hwright_at_apache.org> wrote:
>>...
>> +++ subversion/trunk/subversion/include/svn_editor.h Wed Feb 1 03:50:40 2012
>> @@ -885,6 +885,7 @@ svn_editor_set_props(svn_editor_t *edito
>> * with checksum @a checksum.
>> * ### TODO @todo Does this send the *complete* content, always?
>> * ### TODO @todo What is REVISION for?
>> + * ### TODO @todo Who is responsible for closing the stream?
>
> The receiver does. I'll clarify this in the docco after my API
> changes.
Yeah, I figured that's the answer, I just wasn't sure (and rather than
guess, I figured I'd record my uncertainty to ensure it gets clarified
at some point).
> The receiver has three choices:
>
> 1) close the stream without reading
> 2) close the stream after reading *some* of the content
> 3) close the stream after reading *all* the content
>
> Drivers should generally use a lazy-load technique in case of (1).
> They may not require disk access, resource consumption, etc, if the
> receiver choose to immediately close the stream.
>
> Example: the checksum already exists in the pristine store, so the
> receiver can immediately close the stream [rather than spooling the
> contents into the store].
>
> Cheers,
> -g
--
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Received on 2012-02-01 07:55:11 CET