[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix a bug with property validation logic during 'svnadmin load'

From: vijay <vijay_at_collab.net>
Date: Fri, 27 Jan 2012 12:40:19 +0530

On 01/26/2012 06:44 PM, C. Michael Pilato wrote:
>
> Vijay, I think you have misunderstood what these docstrings are claiming.
>
> They are not saying, "When Subversion calls the FS-loading API, it tends to
> pass FALSE for validate_props by default."
>
> They are describing the quite literal implementation of the older function
> as it related to the newer one. They are saying, "Calling
> svn_repos_load_fs2() is just like calling svn_repos_load_fs3() with all the
> same parameters, except the new parameter validate_props is always FALSE.
>
> Your docstring change above is incorrect, because the implementations of the
> older svn_repos_load_fs2() and svn_repos_get_fs_build_parser2() functions
> has not changed. Furthermore, those old imlementations are not allowed to
> change, because that would change the behaviors of those functions, breaking
> our compatibility promise.

Thanks cmpilato. I got it.

Attaching the updated patch and log message.

Thanks & Regards,
Vijayaguru

Received on 2012-01-27 08:11:23 CET

This is an archived mail posted to the Subversion Dev mailing list.