[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[patch] applying patch can fail with dry_run

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Thu, 12 Jan 2012 19:55:10 +0100

Hi,

When applying a patch in dry-run mode, svn can return an error even if
the patching would work just fine. The returned error is then:
The Node ..../newDirectory was not found

If you want to reproduce this, here's the mailing list thread on the
TSVN mailing list:
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2899409

(steps to reproduce at the bottom, with the patch files attached to that
thread).

Attached here is my patch which would fix this issue: when running in
dry_run mode, the function delete_empty_dirs() isn't executed.
I'm not completely sure but I think that function is only necessary when
the patch is actually applied.

Could someone please review my patch? I'm sure you guys can see
immediately whether this is save or not. If it's ok, then I'll commit it
later.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net

Received on 2012-01-12 19:55:49 CET

This is an archived mail posted to the Subversion Dev mailing list.