Re: Bug: "svnadmin dump --incremental --deltas" gives too much output

On 2009-01-06 23:00:40 +0100, Vincent Lefevre wrote:
> On 2009-01-06 11:20:20 -0500, C. Michael Pilato wrote:
> > I've been sitting on this thread for a looooooooong time. Still no time to
> > really invest here, but I filed issue #3353 so we don't lose this discussion
> > forever.
>
> This is not just a documentation bug: with --incremental --deltas,
> I get a delta on the changed files only (as expected), but the delta
> is too big: it contains a lot of text that hasn't changed. The problem
> is much more important in the latest revisions than in the first ones.

Actually the --incremental option doesn't matter. For instance, it
is not useful when doing a dump from revision 0, and I get exactly
the same bug, as said below.

I've attached two files showing the problem. I've obtained them with:

$ svn diff -c3876 file:///home/vlefevre/private/svn-mpfr > mpfr-diff
$ svnadmin dump --incremental --deltas ~/private/svn-mpfr -r3876 > mpfr-dump
$ ll mpfr-*
-rw-r--r-- 1 vlefevre vlefevre 2590 2011-12-25 22:38:31 mpfr-diff
-rw-r--r-- 1 vlefevre vlefevre 9333 2011-12-25 22:38:34 mpfr-dump

on my own copy of the MPFR repository (to be able to use svnadmin).
This corresponds to a ChangeLog update (note: CVS was used at that
time, and the repository was converted to Subversion later). One
can see in mpfr-diff that there are changes only for 2005-09. But
in mpfr-dump, one can see text corresponding to 2005-09, 2004-09,
2003-01, and 2001-10. Text corresponding to 2001..2004 shouldn't
have appeared as nothing has changed!

I get the same data for the revision 3876 (i.e. removing everything
that doesn't belong to this revision) whether I do

  svnadmin dump --incremental --deltas ~/private/svn-mpfr -r3876

or I do

  svnadmin dump --deltas ~/private/svn-mpfr -r 0:3876

showing that --incremental doesn't matter regarding this bug.

-- 
Vincent Lefèvre <vincent@vinc17.net> - Web: <http://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / Arénaire project (LIP, ENS-Lyon)