[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1222522 - /subversion/branches/1.7.x/STATUS

From: Mark Mielke <mark_at_mark.mielke.cc>
Date: Sat, 24 Dec 2011 19:01:07 -0500

On 12/24/2011 05:54 AM, Stefan Küng wrote:
> Explorer is of course a bigger issue than other apps using the svn
> library. But other UI have the same issue.
> I've mentioned this example before:
> Imagine you're using an image editor (e.g. photoshop, paint.net, ...)
> and instead of showing an error when loading a corrupted image and
> then proceed, they would just show an assert dialog and then exit.
> Do you _really_ think that's how an UI should work?

Heh. That's what Outlook does. :-) Although at least it brings up a
pretty dialog that offers to send crash results to Microsoft and restart.

Hey all. Just reading and I'm surprised that Subversion uses assert() in
production code. I don't think this is typical practice. Is it not
typical practice to enable assert() in development code but remove it
for production? The idea is to provide extra guards during the
development and testing, but not to take down production environments?

My thinking is that if you have production code raise assert(), then the
code is not of sufficient quality to have been released in the first place.

All code has bugs, of course, but from what I'm reading Subversion is
doing something particular in that the developers are treating assert()
as a list of TODO items that are not properly handled and really should
be handled...

-- 
Mark Mielke<mark_at_mielke.cc>
Received on 2011-12-25 01:01:41 CET

This is an archived mail posted to the Subversion Dev mailing list.