[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1222522 - /subversion/branches/1.7.x/STATUS

From: Stefan Sperling <stsp_at_elego.de>
Date: Fri, 23 Dec 2011 14:50:45 +0100

On Fri, Dec 23, 2011 at 02:26:40PM +0200, Daniel Shahaf wrote:
> On Fri, Dec 23, 2011, at 13:01, Stefan Sperling wrote:
> > On Fri, Dec 23, 2011 at 01:48:18PM +0200, Daniel Shahaf wrote:
> > > stsp_at_apache.org wrote on Fri, Dec 23, 2011 at 00:35:16 -0000:
> > > > + An informative error message helps people more than an assert (which
> > > > + in case of TSVN can mean crashing the Windows Explorer).
> > >
> > > I thought the svn_error_malfunction_handler_t stuff addressed that issue?
> >
> > No, because TSVN didn't end up using it as intended.
> > See bottom of http://svn.haxx.se/users/archive-2011-10/0378.shtml
>
> I don't see how that's relevant? That link discusses the error dialogs.
> What I'm asking is whether TSVN has implemented an
> svn_error_malfunction_handler_t that replaces the default handler,
> svn_error_abort_on_malfunction().

Yes it does (called svn_error_handle_malfunction()) but it calls abort()
which means the explorer crashes:
http://tortoisesvn.googlecode.com/svn/trunk/src/SVN/SVN.cpp
Received on 2011-12-23 14:51:21 CET

This is an archived mail posted to the Subversion Dev mailing list.