Re: svn commit: r1222521 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

On Fri, Dec 23, 2011 at 10:40:59AM +0400, Konstantin Kolinko wrote:
> 2011/12/23 Hyrum K Wright <hyrum.wright_at_wandisco.com>:
> > Yikes!  I think this wins the prize for "longest function call".
> > Perhaps a helper function or at least some temporary variables would
> > be in order?

I look into that, sure.

> I would say that the message is not friendly to translators.

That's right. For usual error messages I would care.
In this case I'm not sure though if it is very important to translate
the message. This is meant to help us with debugging.
Maybe we should not mark it for translation.
We'll end up asking people to set LC_ALL=C anyway if we don't recognize
the translated message (though we could probably recognize it quite
easily even if it was translated :)

> Those repos_id, last_repos_id -- are they needed in a message
> displayed to an user?
>
> I would say that URL and UUID should be enough.

The repos_id is useful information for developers trying to help users
with debugging the issue. The message only appears if a bug in Subversion
is triggered. It was an assertion before this commit for a reason.
Received on 2011-12-23 11:26:16 CET