[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1221463 - /subversion/trunk/subversion/mod_dav_svn/repos.c

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 20 Dec 2011 15:26:36 -0500

Do we do this on the command line, too? I was just thinking about that
the other day, when I cut/pasted a command line kinda like:

$ svn diff -c r99999

... then I went back and removed the 'r'. Maybe I should just look myself? :-P

On Tue, Dec 20, 2011 at 15:03, <danielsh_at_apache.org> wrote:
> Author: danielsh
> Date: Tue Dec 20 20:03:50 2011
> New Revision: 1221463
>
> URL: http://svn.apache.org/viewvc?rev=1221463&view=rev
> Log:
> Allow leading "r"'s in mod_dav_svn ?p= and ?r= query string parameters.
>
> * subversion/mod_dav_svn/repos.c
>  (parse_querystring): Skip leading r's in the &p= and &r= arguments.
>
> Modified:
>    subversion/trunk/subversion/mod_dav_svn/repos.c
>
> Modified: subversion/trunk/subversion/mod_dav_svn/repos.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/mod_dav_svn/repos.c?rev=1221463&r1=1221462&r2=1221463&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/mod_dav_svn/repos.c (original)
> +++ subversion/trunk/subversion/mod_dav_svn/repos.c Tue Dec 20 20:03:50 2011
> @@ -1816,6 +1816,8 @@ parse_querystring(request_rec *r, const
>
>   if (prevstr)
>     {
> +      while (*prevstr == 'r')
> +        prevstr++;
>       peg_rev = SVN_STR_TO_REV(prevstr);
>       if (!SVN_IS_VALID_REVNUM(peg_rev))
>         return dav_svn__new_error(pool, HTTP_BAD_REQUEST, 0,
> @@ -1833,6 +1835,8 @@ parse_querystring(request_rec *r, const
>   wrevstr = apr_table_get(pairs, "r");
>   if (wrevstr)
>     {
> +      while (*wrevstr == 'r')
> +        wrevstr++;
>       working_rev = SVN_STR_TO_REV(wrevstr);
>       if (!SVN_IS_VALID_REVNUM(working_rev))
>         return dav_svn__new_error(pool, HTTP_BAD_REQUEST, 0,
>
>
Received on 2011-12-20 21:27:09 CET

This is an archived mail posted to the Subversion Dev mailing list.