Re: 0.2 draft of dumpfile documentation

On Thu, Dec 15, 2011 at 11:44 AM, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> Roderich Schupp wrote on Thu, Dec 15, 2011 at 11:32:40 +0100:
>> I think the latter. The code is in subversion/libsvn_repos/dump.c starting
>> around line 318. Some people might call that an ugly hack :)
>
> Yeah.  I wonder why that code doesn't render a replace-with-history as
> a single "Node-action: replace" "Copyfrom-*: .../" node.

Simple code ab^H^Hreuse. The ...-with-history case needs some additional
consideration and instead of factoring that code out (and leave it to
the caller whether to emit an "add" or "replace") the current implementation
calls itself (i.e. dump_node()) recursively, then fiddles with
must_dump_{text,props}
to cover its tracks.

Cheers, Roderich
Received on 2011-12-15 12:24:52 CET