[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Split up the reintegrate merge API: first find what to do, then do it - v2

From: DanielShahaf <danielsh_at_elego.de>
Date: Mon, 12 Dec 2011 07:48:30 +0200

Julian Foad wrote on Sun, Dec 11, 2011 at 20:53:26 +0000:
> DanielShahaf wrote:
> > Julian Foad wrote on Sun, Dec 11, 2011 at 19:35:04 +0000:
> >> +  if (source->url1)
> >> +    {
> >> +      svn_opt_revision_t revision1
> >> +        = { svn_opt_revision_number, { source->rev1 } };
> >> +      svn_opt_revision_t revision2
> >> +        = { svn_opt_revision_number, { source->rev2 } };
> >
> > ISTR we had trouble in the past with some compilers not allowing these
> > non-constant initializers.  (Fix would be to unroll the initialization
> > into separate lines of code.)
>
> AFAIK we've had this kind of initialization in the Subversion source
> for a long time now, so I'm treating it as de-facto acceptable even
> though not C'89.  I've been writing quite a few of these recently. 
> I can change them all to the long-winded alternative if proven
> necessary, but I hope it's not necessary because I really like the
> brevity.

I don't think it's necessary to change from the style used in the patch
if it works in practice.
Received on 2011-12-12 06:49:35 CET

This is an archived mail posted to the Subversion Dev mailing list.