[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1211162 - /subversion/trunk/subversion/libsvn_wc/context.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Wed, 7 Dec 2011 11:42:16 +0100

> -----Original Message-----
> From: hwright_at_apache.org [mailto:hwright_at_apache.org]
> Sent: dinsdag 6 december 2011 22:22
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1211162 -
> /subversion/trunk/subversion/libsvn_wc/context.c
> Author: hwright
> Date: Tue Dec 6 21:22:08 2011
> New Revision: 1211162
> URL: http://svn.apache.org/viewvc?rev=1211162&view=rev
> Log:
> Fix a potential memory cleanup ordering bug.

This introduces too many other cleanup problems. This makes the context and db unavailable from the normal cleanup handlers in the same pool, that will run as normal cleanup.

The wc_db is carefull to not make assumptions and allocates everything in the same pool and *this* change breaks that by closing the db earlier than those cleanups.

 -0.5 (open for discussion).

If not extremely necessary we should never use a pre-cleanup handler in our code as it just *starts* a race on who can cleanup first and thereby pushes the segfaults in other code

There should be no race: everything should be implemented as a proper last-in, first out.

Received on 2011-12-07 11:43:13 CET

This is an archived mail posted to the Subversion Dev mailing list.