[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: valgrind warning in BDB locks code

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Thu, 24 Nov 2011 16:27:00 +0000

"C. Michael Pilato" <cmpilato_at_collab.net> writes:

> On 11/24/2011 09:39 AM, Philip Martin wrote:
>> Philip Martin <philip.martin_at_wandisco.com> writes:
>>> $ valgrind -q .libs/lt-locks-test 4 --fs-type bdb
>>> ==15971== Invalid read of size 1
>> I've fixed this particular case by r1205839 with an early return. I
>> also committed r1205848 which I think fixes the underlying problem.
> And... backport proposal? (Or is this in newer code?)

The code is present in 1.7 and 1.6 although valgrind doesn't trigger on
1.6. Either one of the revisions will fix the problem. The first fix
is also an optimisation, the second fix is more general. I'm not 100%
sure whether we need second one as well as the first one: I suspect that
the first alone is not enough, but so far I've failed to come up with a
test case to prove that.

uberSVN: Apache Subversion Made Easy
Received on 2011-11-24 17:27:41 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.