[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [RFC] Make mod_dav_svn + mod_authz_svn load-order-independent

From: Greg Stein <gstein_at_gmail.com>
Date: Sun, 20 Nov 2011 15:43:11 -0500

On Nov 20, 2011 12:46 AM, "Peter Samuelson" <peter_at_p12n.org> wrote:
>
>
> Currently if you load mod_authz_svn, you have to make sure mod_dav_svn
> is loaded before it, not after. I'm sure this is usually not a problem
> - but in Debian/Ubuntu, the Apache module machinery enables modules by
> use of tiny config files that each load one module. The filenames
> determine load order, so a config file named 'authz_svn.load' is read
> before one named 'dav_svn.load'.
>
> In the past we got around this by shipping a single 'dav_svn.load' that
> loads _both_ modules, but I never liked that solution, as most people
> don't need mod_authz_svn at all.
>
> Thus, appended is a patch to mod_authz_svn to pull in the two dav_svn
> functions in such a way as to work even if the modules are loaded in
> the "wrong" order.
>
> Question: do we care about breaking third-party Apache modules that use
> the two functions used by mod_authz_svn? (These third-party modules
> would need to do the same thing I'm patching mod_authz_svn to do.) If
> so, we can leave the original prototype in the public mod_dav_svn.h
> instead of moving it, as I've done below.

Yes, we care. I would bet that CollabNet uses them for its custom authz.

Cheers,
-g
Received on 2011-11-20 21:43:45 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.