[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1202783 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Wed, 16 Nov 2011 18:56:56 +0000

Daniel Shahaf <d.s_at_daniel.shahaf.name> writes:

>> fs_fs knows that in this case the root cause is important and that the
>> error chain is mostly useless. mod_dav_svn, and svnserve, cannot know
>> that so would have to print the whole chain in every case.
> "In this case"? How do you know what the case is? It might be a disk
> problem, not just the specific error that triggered your fix.

Getting the rep from the rep-cache database failed. The root error is
the one that matters, whether it is "permission denied" or "wrong sqlite
version" or "i/o error". Recording "failed to open database" is not

> Should we add some SQLite error code to the if() condition whose else()
> branch you patched? For example, "SQLite db is corrupted" would appear
> to be serious enough (if it's not already caught by the

That branch doesn't clear the error, I assume it gets handled elsewhere.

uberSVN: Apache Subversion Made Easy
Received on 2011-11-16 19:57:32 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.