[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1202338 - /subversion/trunk/subversion/libsvn_client/merge.c

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Tue, 15 Nov 2011 18:50:05 +0000 (GMT)

Hyrum K Wright <hyrum.wright_at_wandisco.com> wrote:
> This makes me a little nervous.  I don't know what the compiler
> guarantees are about something allocated on the stack in a sub-block
> within a function, but the above use just looks wrong.  As soon as
> the variable goes out of scope, the compiler may choose to put
> something else on the stack in its place, which in this case would
> lead to memory problems.

Oops, I was too hasty. You're quite right. Thanks for spotting that.

Will fix.

> Perhaps the solution is to move the variable declaration back to
> the top of the file.
> I haven't checked the context to see if this is a problem in the
> other hunk in this change.

Will check.

- Julian
Received on 2011-11-15 19:50:42 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.