[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1200837 - in /subversion/trunk/subversion: svn/commit-cmd.c svn/copy-cmd.c svn/delete-cmd.c svn/import-cmd.c svn/mkdir-cmd.c svn/move-cmd.c tests/cmdline/basic_tests.py

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Fri, 11 Nov 2011 14:26:57 +0200

On Friday, November 11, 2011 12:07 PM, philip_at_apache.org wrote:
> Modified: subversion/trunk/subversion/svn/delete-cmd.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/delete-cmd.c?rev=1200837&r1=1200836&r2=1200837&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/svn/delete-cmd.c (original)
> +++ subversion/trunk/subversion/svn/delete-cmd.c Fri Nov 11 12:07:49 2011
> @@ -79,7 +79,9 @@ svn_cl__delete(apr_getopt_t *os,
> SVN_ERR(svn_cl__eat_peg_revisions(&targets, targets, pool));
>
> err = svn_client_delete4(targets, opt_state->force, opt_state->keep_local,
> - opt_state->revprop_table, svn_cl__print_commit_info,
> + opt_state->revprop_table,
> + (opt_state->quiet
> + ? NULL : svn_cl__print_commit_info),
> NULL, ctx, pool);
> if (err)
> err = svn_cl__may_need_force(err);
>
> Modified: subversion/trunk/subversion/svn/import-cmd.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/import-cmd.c?rev=1200837&r1=1200836&r2=1200837&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/svn/import-cmd.c (original)
> +++ subversion/trunk/subversion/svn/import-cmd.c Fri Nov 11 12:07:49 2011
> @@ -120,7 +120,8 @@ svn_cl__import(apr_getopt_t *os,
> opt_state->no_ignore,
> opt_state->force,
> opt_state->revprop_table,
> - svn_cl__print_commit_info,
> + (opt_state->quiet
> + ? NULL : svn_cl__print_commit_info),
> NULL,

For next time, perhaps it would be better to, instead, pass a baton and
let the callback figure out whether or not to print. *shrug*
Received on 2011-11-11 13:27:33 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.