Re: [PATCH] Fix issue #4049 - SEGV on patch that deletes and skips
On Wed, Nov 9, 2011 at 12:41 PM, Daniel Näslund <dannas_at_dannas.name> wrote:
> On Wed, Nov 9, 2011 at 10:46 AM, Philip Martin
> <philip.martin_at_wandisco.com> wrote:
>> Daniel Näslund <dannas_at_dannas.name> writes:
>> What is not clear to me is why skipped targets get added to targets_info
>> in the first place. How about moving the APR_ARRAY_PUSH inside the
>> !target->skipped section:
>> if (! target->filtered)
>> APR_ARRAY_PUSH(targets_info, ...)
>> if (! target->skipped)
> Doh, looking at it from perspective that appears to be the right fix. No
> changes has been made to skipped targets so no need to check if they've
> been deleted.
> I'll test to see that the patch works with your suggested change and
> commit it later tonight (UTC+1) if no one has any other suggestions.
Committed revision 1199950.
Received on 2011-11-09 21:35:12 CET
This is an archived mail posted to the Subversion Dev