On Sun, Nov 06, 2011 at 07:09:25PM +0400, Konstantin Kolinko wrote:
> Having tests in parse-diff-test.c does not preclude you from adding
> high-level tests to patch_tests.py
>
> As an end-user I do not care about how patch parsing is done, or what
> paths are returned where and what else goes on under the hood.
>
> I do care whether I can apply particular real-live patch. I do care
> whether patches generated from the official git mirrors at
> http://git.apache.org/ can be contributed back to the project.
>
> Adding more real-live test cases does improve the test suite.
Fair eoung, that makes sense. If this is important to you, please
submit a proper patch against the python test suite that makes it
use a real-life diff.
> I need to apply the patch using --strip option. How --strip option
> interoperate with "/dev/null" path is not clear without knowing the
> internals. The tests that I propose to add will cover that.
So we should document somewhere that "/dev/null" is treated specially?
I doubt anyone will get the idea that 'svn patch' would apply the strip
count to "/dev/null", if they haven't run into the same problem as you.
I don't really think it's worth documenting. Once the fix is in 1.7.2,
nobody will notice a problem. Things will "just work".
Received on 2011-11-06 16:36:39 CET