Re: [Issue 4048] wcng fails with 1.0.x servers

"Bert Huijben" <bert_at_qqmail.nl> writes:

>> By experiment 1.0 does not remove incomplete from the whole tree, only
>> from the
>> anchor. svn_wc__do_update_cleanup calls svn_wc__tweak_entry and that
>> doesn't
>> clear incomplete as far as I can see.
>
> If the adm crawler notes an pre-existing incomplete directory, it reports
> that status to the repository. And then the repository sends an update
> report for that directory.

What are you saying? That the fix is wrong? The response from a 1.0.x
server is not the same as that from a modern server.

$ svnadmin-1.0.9 create repo
$ svn mkdir -mm --parents file://`pwd`/repo/A/B/C
$ svnserve-1.0.9 -dr.
$ svn co svn://localhost/repo wc
$ sqlite3 wc/.svn/wc.db "update nodes set presence='incomplete'"
$ svn up wc
$ svn st wc
! wc/A/B/C
$

Not all directories get marked complete.

$ rm -rf wc && svn co svn://localhost/repo wc
$ sqlite3 wc/.svn/wc.db "update nodes set presence='incomplete'"
$ sqlite3 wc/.svn/wc.db "delete from nodes where local_relpath='A/B/C'"
$ rmdir wc/A/B/C
$ svn up wc
A wc/A/B/C
$ svn st wc
$

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com