[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1196191 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Wed, 02 Nov 2011 12:59:31 +0000

Stefan Sperling <stsp_at_elego.de> writes:

> On Tue, Nov 01, 2011 at 06:36:26PM +0000, Philip Martin wrote:
>> Is sorting in C better than putting UNIQUE on the local_relpath column?
> I don't know. I don't mind either way. Let's pick whichever is faster.
> The notification/cancellation fix is needed in either case.

I think the cacellation change is wrong. This is happening inside an
SQLite transaction. When the user cancels a delete operation during
notification the cancel callback will return an svn_error_t causing the
transaction to abort. That means that no change will have been made to
the database. I don't see how postponing that abort until all the
notifications have been made is an improvement.

uberSVN: Apache Subversion Made Easy
Received on 2011-11-02 14:00:11 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.