[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1196191 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Tue, 01 Nov 2011 18:36:26 +0000

stsp_at_apache.org writes:

> Author: stsp
> Date: Tue Nov 1 18:26:54 2011
> New Revision: 1196191
>
> URL: http://svn.apache.org/viewvc?rev=1196191&view=rev
> Log:
> During 'svn rm', sort the delete-list in C, rather than in SQL.
> This speeds up 'svn rm dir/*'.
>
> Also fix notification in case of cancellation. We were omitting notification
> for some nodes in the delete-list if the user cancelled early. This is wrong
> because all nodes in the delete-list are already deleted at this point.
>
> * subversion/libsvn_wc/wc-queries.sql
> (STMT_SELECT_DELETE_LIST): Don't ORDER BY.
>
> * subversion/libsvn_wc/wc_db.c
> (do_delete_notify): Sort the delete-list in C, if it is not already sorted.
> Notify for all paths in the delete-list before allowing cancellation.

Is sorting in C better than putting UNIQUE on the local_relpath column?

-- 
Philip
Received on 2011-11-01 19:37:05 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.