[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Make SQLite compatibility check less picky

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sat, 29 Oct 2011 14:08:07 +0200

On Saturday, October 29, 2011 6:45 AM, "Jonathan Nieder" <jrnieder_at_gmail.com> wrote:
> Hi,
>
> This patch is taken from Debian's subversion packaging. It avoids
> having to rebuild Subversion each time an older or newer patchlevel of
> SQLite gets installed (i.e., the x in 3.7.x changes). I'd appreciate
> any thoughts you have.
>
> Thanks,
> Jonathan
>
> [[[
> The actual ABI compatibility of sqlite3 doesn't depend on the patchlevel
> (the x in 3.7.x),

[citation needed]

(I already searched sqlite.org for "ABI" and "binary compatibility" and so on; zero matches)

> so stop being picky about the patchlevel when checking
> the version number at runtime. This avoids spurious errors of the form
> "svn: Couldn't perform atomic initialization" / "svn: SQLite compiled
> for 3.7.4, but running with 3.7.3" when sqlite gets a minor update
> without Subversion being rebuilt to match.
>
> @@ -772,7 +772,7 @@ svn_sqlite__open(svn_sqlite__db_t **db, const char
> */
> {
> int ignored_err = SQLITE_OK;
> -#if !SQLITE_VERSION_AT_LEAST(3,7,8) && defined(SQLITE_SCHEMA)
> +#if defined(SQLITE_SCHEMA)
> if (!strcmp(sqlite3_libversion(), "3.7.7"))

This seems to be an independent change. I assume you're guarding against a downgrade of libsqlite3.so?

> ignored_err = SQLITE_SCHEMA;
> #endif
>
Received on 2011-10-29 14:08:40 CEST

This is an archived mail posted to the Subversion Dev mailing list.