[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Update to SQLite amalgamation instructions.

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Fri, 28 Oct 2011 17:49:33 +0200

On Friday, October 28, 2011 11:35 AM, "Karl Fogel" <kfogel_at_red-bean.com> wrote:
> Daniel Shahaf <d.s_at_daniel.shahaf.name> writes:
> >Daniel Shahaf wrote on Fri, Oct 28, 2011 at 09:19:37 +0200:
> >> Karl Fogel wrote on Thu, Oct 27, 2011 at 23:28:43 -0400:
> >> > It's been a while, so out of caution I'd appreciate review on this
> >> > before I commit, even though it's a fairly trivial patch. Thanks!
> >> >
> >>
> >> Why did you drop the direct link to the .tgz? The log message doesn't
> >> say, and I know that elsewhere
> >
> >get-deps.sh
>
> Because the URL was broken (see log msg). And it seems likely that no
> version-specific URL for this is likely to stay valid for long.
>
> However, if that was the only reason we were computing the URL, then the
> computation should be removed too. I'll take a look.
>

We could construct the URL as currently valid and also link to the download page. That way people can click the first link and also have the second if the first breaks.

> Thanks!
>
> -Karl
>
> >> we do some printf(1) magic to compute it.
> >>
> >> > -SQLITE_URL="http://www.sqlite.org/sqlite-amalgamation-${SQLITE_RECOMMENDED_VER}.tar.gz"
> >> > +SQLITE_AMALGAMATION_URL="http://sqlite.org/download.html"
>
Received on 2011-10-28 17:50:04 CEST

This is an archived mail posted to the Subversion Dev mailing list.